Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-vite): turn off react/jsx-no-target-blank ESLint rule in React JS template #15672

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

ArnaudBarre
Copy link
Member

Adresses: #13750 (comment)

Changing it upstream has already been suggested: jsx-eslint/eslint-plugin-react#3552

Copy link

stackblitz bot commented Jan 21, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@ArnaudBarre ArnaudBarre changed the title Turn off react/jsx-no-target-blank ESLint rule in React JS template fix(create-vite): turn off react/jsx-no-target-blank ESLint rule in React JS template Jan 21, 2024
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I didn't know it was error-ing before. I'm curious why the TypeScript variant have a different eslint config setup though.

@ArnaudBarre
Copy link
Member Author

The goal was to provide a minimal setup to have ESLint running, and for TS the react plugin is not needed

@patak-dev patak-dev merged commit a6f39e8 into main Jan 22, 2024
10 of 11 checks passed
@patak-dev patak-dev deleted the arnaud/edit-react-lint-config branch January 22, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants